Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runs get to use cursor-based pagination #273

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Aug 21, 2024

Why?

See galasa-dev/projectmanagement#1921

Changes

  • Instead of iterating through page numbers, runs get now uses the cursor provided in responses from /ras/runs to go through pages of run results

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-qx7nh for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-k4575 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-q2dl7 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-7kdth for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-fxxtc for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-b7mrx for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-rz742 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-bdk64 for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-2j9nh for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-273-2cglq for details. If you are unable to do so, please contact a member of the Galasa team.

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@eamansour eamansour merged commit 06a819d into main Aug 27, 2024
6 checks passed
@eamansour eamansour deleted the iss1921-runs-get-performance branch August 27, 2024 14:28
aashir21 pushed a commit that referenced this pull request Sep 18, 2024
* Use cursor-based pagination when getting runs from the API server

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Remove includeCursor query parameter

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Swap cursor condition order

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Turn on includeCursor parameter

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Remove log statement

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

* Use 'from:desc' as the default sort for runs get

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>

---------

Signed-off-by: Eamonn Mansour <47121388+eamansour@users.noreply.github.com>
Signed-off-by: Aashir Siddiqui <aashir_sidiki@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants